nats-io / nats.js / 14248085491
86%

DEFAULT BRANCH: main
Ran
Jobs 7
Files 64
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 84.536% (+0.002%) from 84.534%
14248085491

push

github

web-flow 
Additional hardening of the object store client (#256)

* Additional hardening of the object store client

- made obj put publish messages sequentially - as current server can drop requests when the producer is too fast. This will degrade put performance.

- changed the internal push consumer used on get, to have an idle_heartbeat, if this fires, the get has stalled, and the ordered consumer should reset.

enabled flow control on the ordered consumer, this prevents slow consumers when the client is getting very large objects

Signed-off-by: Alberto Ricart <alberto@synadia.com>

* - hardening of the PullConsumer implementation, by default ordered consumers set flow control and idle_heartbeats. This enables the ordered consumer to self-recreate on `heartbeats_missed`, simplifying watcher/lister configurations.

- objectstore doesn't require listening to heartbeats_missed, since the pull consumer handles it automagically.

- objectstore watch added a check in watch for `heartbeat` notifications - if the watcher is only listing history this is a hint to stop as all records have been processed.

Signed-off-by: Alberto Ricart <alberto@synadia.com>

---------

Signed-off-by: Alberto Ricart <alberto@synadia.com>

2370 of 3217 branches covered (73.67%)

Branch coverage included in aggregate %.

10 of 23 new or added lines in 3 files covered. (43.48%)

4552 existing lines in 36 files now uncovered.

10170 of 11617 relevant lines covered (87.54%)

768618.27 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
3
53.22
 -22.24% jetstream/src/pushconsumer.ts
10
82.27
 -1.01% obj/src/objectstore.ts

Uncovered Existing Lines

Lines Coverage ∆ File
3
45.65
 -6.52% core/src/encoders.ts
7
62.5
 -29.17% transport-deno/src/connect.ts
19
35.56
 -42.22% core/src/core.ts
22
58.95
 -23.16% jetstream/src/types.ts
26
11.86
 -44.07% core/src/heartbeats.ts
28
32.35
 -41.18% core/src/transport.ts
32
64.5
 -18.93% jetstream/src/jsbaseclient_api.ts
37
21.49
 -30.58% core/src/authenticator.ts
43
32.88
 -58.9% jetstream/src/jsutil.ts
52
10.98
 -63.41% core/src/idleheartbeat_monitor.ts
53
22.55
 -22.55% core/src/ipparser.ts
53
24.04
 -50.96% core/src/muxsubscription.ts
53
61.33
 -23.56% jetstream/src/jsclient.ts
57
20.63
 -25.53% core/src/denobuffer.ts
58
17.31
 -55.51% core/src/msg.ts
58
21.0
 -58.0% jetstream/src/jslister.ts
64
15.38
 -54.7% core/src/databuffer.ts
66
36.02
 -35.48% core/src/errors.ts
66
34.33
 -49.25% core/src/semver.ts
69
38.78
 -35.2% core/src/options.ts
91
10.34
 -44.83% core/src/util.ts
95
36.79
 -44.81% jetstream/src/jsmsg.ts
97
18.42
 -63.82% core/src/request.ts
111
53.22
 -22.24% jetstream/src/pushconsumer.ts
121
40.43
 -52.67% core/src/queued_iterator.ts
130
36.11
 -61.09% jetstream/src/jserrors.ts
133
36.59
 -48.19% jetstream/src/jsmconsumer_api.ts
152
16.41
 -28.92% core/src/nats.ts
160
23.0
 -51.12% core/src/servers.ts
164
23.56
 -48.4% core/src/headers.ts
165
27.68
 -46.81% transport-deno/src/deno_transport.ts
287
17.93
 -61.99% jetstream/src/jsm_direct.ts
296
46.2
 -38.05% jetstream/src/jsmstream_api.ts
446
35.43
 -39.16% core/src/parser.ts
579
19.3
 -63.14% jetstream/src/consumer.ts
659
22.29
 -49.9% core/src/protocol.ts
Subprojects
ID Flag name Job ID Ran Files Coverage
1 transport-deno 14248085491.1 34
9.45
 GitHub Action Run
2 services 14248085491.2 39
51.24
 GitHub Action Run
3 obj 14248085491.3 52
43.55
 GitHub Action Run
4 kv 14248085491.4 53
46.79
 GitHub Action Run
5 transport-node 14248085491.5 3
85.07
 GitHub Action Run
6 jetstream 14248085491.6 49
67.17
 GitHub Action Run
7 core 14248085491.7 34
89.46
 GitHub Action Run
Source Files on build 14248085491