uber / ringpop-go / 1451

95%

push

travis-ci

Status refactor 1: Refactor membership to use localMember as the source of truth (#159)

* With this refactor we keep an explicit copy of what the local state of a member is and reincarnate from there if we receive a gossip that would overwrite the state of our node in the network.

* write data for checksum string directly to the buffer.

* remove redundant test.

* scrub source information from a change instead of copying the data back and forth.

* unexport genChecksumString because of locking requirements.

* better explain the copy of gossip to member

* make slices with initial sizes big enough for the max number of elements

* Refactor reincarnationChange to bumpIncarnation,

also reused it at applicable locations.

* Remove unused code.

* Add table test for acceptGossip.

* Document lock requirement on getJoinPosition.

* Rename acceptGossip to shouldProcessGossip.

* Remove TODO comment

* fixed misspelling

* Remove MakeLeave function as it is only used during testing to get the membership into a certain state, instead we will use Update with crafted changes for this as that is the most public interface to interact with the membership. (#161)

201 of 201 new or added lines in 7 files covered. (100.0%)

4124 of 4352 relevant lines covered (94.76%)

3.14 hits per line