Jaded-Encoding-Thaumaturgy / vs-jetpack / 14233061884

66%

push

github

vskernels: Replace `__init_subclass__` by a metaclass and instantiation check (#51)

The current implementation of `vskernels` checks the inherited classes
within the `__init_subclass__` method defined in `BaseScaler` when the
classes are constructed.

However, this approach has several issues:
- The `abstract_kernels` list is hardcoded with default values in a
separate location, leading to a cumbersome design where you have to wait
for these abstract classes to load.
- Abstract classes are bypassed and can be instantiated by the user,
even if they haven't specified a kernel radius.
- Declaring "abstract" classes in a `__abstract__` list at the top of
the file is misleading and questionable. These classes aren't truly
abstract since they can still be instantiated, and the kernel radius
check is simply skipped.

My proposed solution:
- Add a metaclass to `BaseScaler` to explicitly define abstract
classes—those that shouldn't be instantiated.
- Introduce a `partial_abstract` argument to bypass the kernel radius
check, preserving the current behavior for classes like
`vsscale.GenericScaler`.
- Classes like `Scaler` or `Kernel` will NOT continue to function as they did before. They will throw an error at class instantiation.
- The `kernel_radius` check will occur during class instantiation rather
than class construction, eliminating the need to explicitly add an
abstract argument when defining the abstract interface.
- All logic will be contained within the same file, avoiding scattered
code across multiple files.

25 of 29 new or added lines in 3 files covered. (86.21%)

3613 of 6063 relevant lines covered (59.59%)

1.19 hits per line