Ouranosinc / xscen / 14229156819

90%

push

github

Fix 568 (#569)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #568 
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [x] (If applicable) Tests have been added.
- [x] This PR does not seem to break the templates.
- [x] CHANGELOG.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?

* Fixes 2 issues:
* `converted_var = xr.where(ds[var] == -9999, missing, ds[var])` somehow
also removed attributes in `ds` itself, which I'm not quite sure why.
This is the core of the issue for #568.
* `ds[var] = converted_var` was not really mutable-safe, although we
already did a `ds = ds.copy()` at the start.

### Does this PR introduce a breaking change?

* No.

### Other information:

2 of 2 new or added lines in 1 file covered. (100.0%)

3961 of 4504 relevant lines covered (87.94%)

5.22 hits per line