|
Ran
|
Jobs
1
|
Files
518
|
Run time
454min
|
Badge
README BADGES
|
push
github
box: check if iterator was created when loading WAL GC consumers We load WAL GC consumers right after recovery - it is done by iterating over space `_gc_consumers`. However, we forgot to check if the iterator is successfully created, hence, in the case of OOM right after recovery, Tarantool will crash because iterator is NULL. The commit adds the check. Along the way, let's log an explanatory message when we fail to load consumers to make the problem clear. Also, this message will allow us to write a more stable test. Closes tarantool/security#135 NO_CHANGELOG=barely reproducible by user NO_DOC=bugfix (cherry picked from commit 6c7827a0b)
69944 of 123821 branches covered (56.49%)
4 of 4 new or added lines in 2 files covered. (100.0%)
48 existing lines in 16 files now uncovered.102950 of 117698 relevant lines covered (87.47%)
2186597.71 hits per line
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 1 |
95.36 |
-0.31% | src/box/raft.c |
| 1 |
96.12 |
-0.18% | src/box/relay.cc |
| 1 |
95.68 |
-0.72% | src/box/vy_point_lookup.c |
| 1 |
96.3 |
-3.7% | src/cpu_feature.c |
| 1 |
90.38 |
-1.92% | src/lib/core/trigger.cc |
| 2 |
95.84 |
-0.11% | src/box/iproto.cc |
| 2 |
87.3 |
0.0% | src/box/vy_run.c |
| 3 |
91.4 |
0.0% | src/box/box.cc |
| 3 |
97.95 |
-0.22% | src/box/memtx_tx.c |
| 3 |
92.42 |
0.0% | src/box/vinyl.c |
| 3 |
84.18 |
-0.23% | src/box/xlog.c |
| 3 |
97.26 |
-0.3% | src/lib/msgpuck/msgpuck.h |
| 3 |
22.64 |
-0.06% | src/lib/uri/uri_parser.c |
| 4 |
93.31 |
-1.27% | src/lib/swim/swim_io.c |
| 8 |
60.42 |
-3.55% | src/lib/core/fio.c |
| 9 |
88.14 |
-7.63% | src/box/vy_regulator.c |
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 14214174344.1 | 518 |
87.47 |
GitHub Action Run |
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line | Branch Hits | Branch Misses |
|---|