neo-project / neo / 14214448420

79%

Build Type

push

github

Committed by web-flow

Commit Message

Native: swap Policy's `[get/set]AttributeFee` implementations (#3859)

* Native: swap Policy's `[get/set]AttributeFee` implementations

Problem:

`[get/set]AttributeFee` method of native Policy contract has two
implementations: pre-Echidna and post-Echidna (ref. #3175). The problem
is that two implementaitons of this method have reversed
ActiveIn/ActiveTill meaning.

Solution:

GetAttributeFeeV0 implementaiton of Policy's `getAttributeFee` method
should be enabled *till* Echidna, whereas GetAttributeFee should be
enabled *starting from* Echidna. The same is relevant for
SetAttributeFeeV0 and SetAttributeFeeV1 implementations.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* Native: rename Policy's GetAttributeFee to GetAttributeFeeV1

This renaming allows to avoid bugs and collisions with
ActiveIn/ActiveTill. Also, this renaming follows the setters style (for
setters we have `SetAttributeFeeV0` and `SetAttributeFeeV1`.

No functional changes, just a refactoring. Contract manifest is not affected.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

---------

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: NGD Admin <154295625+NGDAdmin@users.noreply.github.com>

Run Details

6115 of 8856 branches covered (69.05%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 2 files covered. (100.0%)

6 existing lines in 1 file now uncovered.

22320 of 27358 relevant lines covered (81.58%)

125507.5 hits per line