kubevirt / containerized-data-importer / #5207
49%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 155
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 59.329% (-0.05%) from 59.378%
#5207

push

travis-ci

web-flow 
MTV-1699 Avoid potentially exceeding memory limit in multi-stage VDDK imports. (#3559)

* Move VDDK code around to reduce memory usage.

Storing multiple QueryChangedDiskAreas results could potentially exceed
importer pod memory limits, so rework the code to iterate over one
result at a time.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

* Update VDDK multi-stage unit tests.

There is no longer an easily-accessible list of changed blocks to check,
so these tests need to let TransferFile run and mock everything that
does.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

* Fix failing unit tests, rename mockable Stat.

MockableStat is a stronger signal for something unusual.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

* Remove some unit test debug logging.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

* Avoid logging out of VMware until transfer is done.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

* Avoid early break in VDDK delta copy.

This block was preventing the actual data copy in some situations, when
it only really needs to avoid the next call to QueryChangedDiskAreas.
Move it after the copy.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

* Avoid potential crash finding snapshot information.

This is mostly cosmetic as the importer pod isn't going to be able to
transfer anything anyway, but an error message is nicer than a panic.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

* Correct changed block area copy loop.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

* Un-break filesystem imports.

The initial transfer creates data.img, only subsequent delta copies need
to fail if it isn't there.

Signed-off-by: Matthew Arnold <marnold@redhat.com>

---------

Signed-off-by: Matthew Arnold <marnold@redhat.com>

68 of 101 new or added lines in 1 file covered. (67.33%)

16 existing lines in 3 files now uncovered.

16802 of 28320 relevant lines covered (59.33%)

0.66 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
33
61.37
 -1.05% pkg/importer/vddk-datasource_amd64.go

Uncovered Existing Lines

Lines Coverage ∆ File
1
61.37
 -1.05% pkg/importer/vddk-datasource_amd64.go
4
74.58
 -1.12% pkg/importer/http-datasource.go
11
71.88
 -2.32% pkg/importer/registry-datasource.go
Jobs
ID Job ID Ran Files Coverage
1 #5207.1 155
59.33
Source Files on build #5207