CSCfi / metadata-submitter / 14172308686

72%

master: 68%

Build Type

push

github

Committed by mradavi

Commit Message

Patch submission files and other minor fixes (merge commit)

Merge branch 'refactor/patch-files-for-submission' into 'main'
* Update OpenAPI specifications

Refactoring post/put files into submission to
patch requests required documentation updates.
At the same time I found some other things to improve
with the OpenAPI specs.

* Unify post and put submission files

In actuality it's a PATCH operation and having both
POST and PUT requests for altering the files list
in submission didn't seem reasonable anymore.

* Error when submission by the same name already exists

Previously you could create a submission with same exact name
and this didn't seem correct to me. So this just checks that
the same submission name doesn't appear in the same project.

* Fix some typos

* Refactor patch operations to submission

* Reduce deprecation warnings

Unit tests produce some warnings about the
datetime.utcnow() method being deprecated

* Simplify get_submission_field behavior slightly

Closes #828, #830, and #864
See merge request https://gitlab.ci.csc.fi/sds-dev/sd-submit/metadata-submitter/-/merge_requests/962

Approved-by: Hang Le <lhang@csc.fi>
Approved-by: Monika Radaviciute <mradavic@csc.fi>
Co-authored-by: Joonatan Mäkinen <joonatan.makinen@csc.fi>
Merged by Monika Radaviciute <mradavic@csc.fi>

Run Details

47 of 51 new or added lines in 4 files covered. (92.16%)

1 existing line in 1 file now uncovered.

2929 of 4028 relevant lines covered (72.72%)

0.73 hits per line