rust-bitcoin / rust-bitcoin / 14139671848

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4289: [hashes] Disable fixed-time equality cmp when building for fuzzers, use fixed-time equality for `Hmac`

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/2d9e240fb6ae13e6139713f9bb8ccb51e5dc0bff">2d9e240fb<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3748bfcd66a67c58c8813d7a428c503e10b5cea1"> [hashes] Use `fixed_time_eq` for `Hmac::eq` (Matt Corallo)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/7ac72730133507b3597611a55d6e7848aece74e2">7ac727301</a> [hashes] Disable fixed-time equality cmp when building for fuzzers (Matt Corallo)

Pull request description:

  Fuzzers want to break memcmp calls into separate comparisons for coverage monitoring, allowing them to not-quite-brute-force find inputs that fully match. Thus, we disable our fancy fixed-time comparison when built with the `hashes_fuzz` cfg.

ACKs for top commit:
  Kixunil:
    ACK 2d9e240fb6ae13e6139713f9bb8ccb51e5dc0bff
  apoelstra:
    ACK 2d9e240fb6ae13e6139713f9bb8ccb51e5dc0bff; successfully ran local tests

Tree-SHA512: 372e344ae4bbc4ca916c15286e88b863463

Coverage Stats

40 of 40 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

22241 of 26621 relevant lines covered (83.55%)

16759.5 hits per line