dart-lang / native / 14134165751

51%

Build Type

push

github

Committed by web-flow

Commit Message

[native_assets_cli] Namespace asset types (#2142)

Bug: https://github.com/dart-lang/native/issues/2132

This PR starts recognizing `code_assets/code` and `data_assets/data` as asset types besides `native_code` and `data`.

The `config.build_asset_types` now contains `["code_assets/code", "native_code"]` for code assets and `["data_assets/data", "data"]` for data assets.

The asset `type`s are still written as the old `"data"` and `"native_code"` to prevent breaking combinations with older hooks and SDKs.

### PR changes

* `pkgs/hooks`, `pkgs/code_assets`, and `pkgs/data_assets`
  * Add new syntax nodes for the new asset types.
    * These new nodes don't inline all the encoding in the object itself, encoding is only in `encoding`.
  * Adds test data with the new asset keys.
  * Added JSON schema tests that exercise the new asset keys.

* `package:native_assets_cli`
  * Recognize code and data assets with both the old a new asset keys.
  * Emit both old and new asset type in `config.build_asset_types`.
  * Emit the old asset type in assets for now.

Coverage Stats

6 of 66 new or added lines in 8 files covered. (9.09%)

289 existing lines in 7 files now uncovered.

13793 of 16196 relevant lines covered (85.16%)

35.3 hits per line