kubeflow / trainer / 14132728736

51%

push

github

[feature]:add validations for MPIRuntime with RunLauncherAsNode (#2551)

* [feature]:add validatioons for MPIRuntime with RunLauncherAsNode

Signed-off-by: Harshal292004 <malaniharshal95@gmail.com>

* fix:changed "launcher" and "node" with constants

Signed-off-by: Harshal292004 <malaniharshal95@gmail.com>

* fix:removed the constants with string values

Signed-off-by: Harshal292004 <malaniharshal95@gmail.com>

* fix: add nil checks for before derefrencing pointers

Signed-off-by: Harshal292004 <malaniharshal95@gmail.com>

* fix:add check for trainjob being nil

Signed-off-by: Harshal292004 <malaniharshal95@gmail.com>

* updae with suggestions

Signed-off-by: Harshal292004 <malaniharshal95@gmail.com>

* update with suggestions

Signed-off-by: Harshal292004 <malaniharshal95@gmail.com>

* Update pkg/runtime/framework/plugins/mpi/mpi.go

Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: Harshal Malani <142563202+Harshal292004@users.noreply.github.com>

* Update pkg/runtime/framework/plugins/mpi/mpi.go

Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: Harshal Malani <142563202+Harshal292004@users.noreply.github.com>

* fix merge conflicts

Signed-off-by: Harshal292004 <malaniharshal95@gmail.com>

* test(runtime): add UT for mpi runtime validate function

Signed-off-by: Harshal292004 <malaniharshal95@gmail.com>

* Update mpi and mpi_test according to suggestions

Signed-off-by: Harshal292004 <malaniharshal95@gmail.com>

* Update mpi_test

Signed-off-by: Harshal292004 <malaniharshal95@gmail.com>

---------

Signed-off-by: Harshal292004 <malaniharshal95@gmail.com>
Signed-off-by: Harshal Malani <142563202+Harshal292004@users.noreply.github.com>
Co-authored-by: Yuki Iwai <yuki.iwai.tz@gmail.com>

6 of 6 new or added lines in 1 file covered. (100.0%)

1735 of 2610 relevant lines covered (66.48%)

2.21 hits per line