dart-lang / native / 14109430393

76%

Build Type

push

github

Committed by web-flow

Commit Message

[native_assets_cli] Make `CodeAsset` `os` and `architecture` optional in JSON (#2139)

Bug: https://github.com/dart-lang/native/pull/2138

This makes the OS and architecture optional in the syntax and the internals in the semantic API (after https://github.com/dart-lang/native/pull/2138 they are no longer available in the semantic API).

The validation logic still checks that the OS and architecture is consistent with the `CodeConfig`.

(We cannot remove them yet, because link hooks can rely on these fields being present in the input if they were present in the build hook output. The previous PR fixed one such case. So we'll leave that cleanup to later once the removal of the API has rolled everywhere.)

Run Details

20 of 30 new or added lines in 3 files covered. (66.67%)

5 existing lines in 2 files now uncovered.

13751 of 16135 relevant lines covered (85.22%)

35.27 hits per line