tarantool / tarantool / 14101951805

86%

master: 88%

Build Type

push

github

Committed by sergepetrenko

Commit Message

gc: use *.snap st_mtime to schedule after restart

Introduce the `timestamp` field in `gc_checkpoint` so now `gc.{c,h}` are
aware of actual times of checkpoints, which is important since this
subsystem is responsible for scheduling. Now, one can track the unix time
of a new checkpoint with new `timestamp` argument of `gc_add_checkpoint`.
This change allows us to track previous checkpoints made before the
server restart and even `checkpoint_interval` value reconfiguring.

This approach was chosen instead of just scanning the `snap_dir` in
`gc.c` because it was engine-independent. One may also notice that even
if the actual time after the last snapshot before the restart is greater
than `2 * checkpoint_interval` we won't start checkpointing immediately
because that may cause high disk load in case of multiple instances. So
in this case we just schedule a checkpoint at a random moment in the
first `checkpoint_interval` seconds after the restart. It seems like
even with this scheduling strategy a snapshot will be eventually created
even during constant restarting.

Fixes #9820
NO_DOC=bugfix

(cherry picked from commit d590c7252)

Run Details

63479 of 114824 branches covered (55.28%)

16 of 17 new or added lines in 3 files covered. (94.12%)

26 existing lines in 11 files now uncovered.

94424 of 109688 relevant lines covered (86.08%)

1907966.27 hits per line