zooniverse / front-end-monorepo / 14094092688

77%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(lib-classifier): restore image context menu for subjects (#6787)

* refactor(lib-classifier): restore image context menu for subjects

- convert `ZoomEventLayer` to an SVG group, so that it wraps subject images rather than obscuring them.
- prevent default pointer down events on images, so that we can drag them without triggering the browser's built-in image drag-and-drop.
- cancel pointer events when we're drawing on scatter plots, so that marking a data range doesn't also move the underlying plot.

* allow VisXZoom to have children

* make images focusable

* add tests

* convert `VisXZoom` children to a render prop

* ignore the mouse wheel in drawing mode

* Remove passive wheel events and fix enzyme tests

* add a disabled prop to ZoomEventLayer

* ZoomEventLayer: improve the autofocus handler

* whitespace

* tidy up pointer event cancelling

* ignore clicks to close transcription popups

* update a couple of DOM attribute tests

* allow subject image to fire keyboard events

* remove event handlers when ZoomEventLayer is disabled

* make chart backgrounds focusable

* remove unused declarations

---------

Co-authored-by: Mark Bouslog <mcbouslog@gmail.com>

Run Details

11005 of 16802 branches covered (65.5%)

Branch coverage included in aggregate %.

26 of 28 new or added lines in 8 files covered. (92.86%)

11 existing lines in 4 files now uncovered.

17130 of 20446 relevant lines covered (83.78%)

401.58 hits per line