Neptune-Crypto / neptune-core / 14085864446

75%

Build Type

push

github

Committed by web-flow

Commit Message

Merge PR #516: Regular Prover Fee Notifications

 - Introduces a CLI flag that regulates the notification policy for prover fees (meaning upgrader fees and composition fees, guesser fees are explicitly excluded). The notification policy can be
   - OnChainSymmetric (default)
   - OffChain (for users who know what they are doing)
   - OnChainGeneration (anticipates cold composing/upgrading, where the client mines to an address but does not know the spending key).
 - Streamlines the CLI arguments, and how it is passed down to global state and wallet state.
 - Implements and tests the fee notification policy.
 - Automatically derives and tracks the symmetric (in addition to generation, which was already being done) key with derivation index 0. The default fee notification policy is to use this symmetric key.
 - Adds a step in scan mode when scan mode is active, unrelated to fee notification policy, which tries to reproduce the composer UTXOs and claims them if successful.
 - Modifies the insertion policy into the mempool: expand the definition of "proof quality" to prefer more up-to-date transactions.

Fixes #441.
Closes #443.

Run Details

1045 of 1095 new or added lines in 18 files covered. (95.43%)

15 existing lines in 5 files now uncovered.

51689 of 61269 relevant lines covered (84.36%)

176217.86 hits per line