dart-lang / native / 14085150779

76%

Build Type

push

github

Committed by web-flow

Commit Message

[native_assets_cli] Nest `config` extensions (#2133)

Closes: https://github.com/dart-lang/native/issues/2091

Nests the extension configurations under an `extension` key in `config`:

```json
{
  "config": {
    "code": { // old location
      "android": {
        "target_ndk_api": 21
      },
      "link_mode_preference": "dynamic"
    },
    "extensions": {
      "code_assets": { // new location, scoped by package name
        "android": {
          "target_ndk_api": 21
        },
        "link_mode_preference": "dynamic"
      }
    }
  },
}
```

### PR changes

* `pkgs/hook` and `pkgs/code_assets`
  * Introduces new schemas in the non-generated `.schema.json` files.
  * Adds deprecation and version skew notice in schemas. (And update the generated schema to pick these comments up.)
  * Adds test data for the new location.
  * Added JSON schema tests for the new location

* `package:native_assets_cli`
  * Generated the syntax classes.
  * Deal with version skew in the mapping between syntax classes and semantic API.
  * Fix tests that deal with syntax errors.

### Version skew between hooks and SDKs

* Backwards compatibility older hooks: Still emit `config.code`.
* Backwards compatibility older SDKs: Also read `config.extensions.code_config`.

Run Details

33 of 55 new or added lines in 3 files covered. (60.0%)

2 existing lines in 2 files now uncovered.

13763 of 16012 relevant lines covered (85.95%)

35.55 hits per line