tarantool / tarantool / 14084552938

88%

Build Type

push

github

Committed by locker

Commit Message

vinyl: do not reset cache link LSN on partial key lookup

Since commit e8109b2fe0b3 ("vinyl: ignore cache chains with invisible
DELETEs") each cache node stores the LSNs of the left and right links.
They are used to ignore links that are invisible from the current read
view (created after the read view was opened). We update the LSN not
only when we link two nodes together but also when we update the node's
boundary level. This is incorrect if the node is linked.

For example, suppose we have an index over two fields that contains
tuples {0,2} and {2,0} and there's a transaction that was sent to
a read view. Now another transaction inserts {0,1} and deletes {0,2},
then selects all tuples. This results in creation of two interlinked
cache nodes: {0,1} and {2,0}. The link is invisible from the read view:
since we skipped DELETE{0,2}, its LSN equals the LSN of the DELETE
statement, which is greater than the read view LSN. However, if we now
select GT{1}, we will update the boundary level of the node storing
{2,0} from 2 to 1 and reset its LSN to 0 because we didn't skip any
DELETE statements. As a result, if the transaction operating in the read
view tries to select GT{0,1}, it will find {2,0}, see that it's
left-linked and the link LSN is 0, and return it right away, skipping
{0,2}, which is visible from the read view.

To fix this issue, let's skip the boundary level update if the node
is linked. It doesn't make sense anyway because the boundary level is
used only for unlinked nodes, see vy_cache_iterator_is_stop().

Follow-up #11079
Closes #11294

NO_DOC=bug fix

Run Details

70102 of 123641 branches covered (56.7%)

2 of 2 new or added lines in 1 file covered. (100.0%)

33 existing lines in 14 files now uncovered.

103200 of 117965 relevant lines covered (87.48%)

2881289.37 hits per line