dart-lang / native / 14077879620

76%

Build Type

push

github

Committed by web-flow

Commit Message

[native_assets_cli] Prevent `EncodedAsset` and `Metadata` hashcode changing (#2131)

Closes: https://github.com/dart-lang/native/issues/2045

We have two types of classes in the semantic API:

1. Pure views on top of a JSON.
   These classes are mirrored by a builder class.
   Objects from these classes cannot be passed from input to output in hooks.
   These classes do not override `hashCode` and `operator ==`.
   Examples: `CodeConfig`, `BuildInput`.
2. Data classes that eagerly copy all fields out of the JSON.
   These classes have a public constructor with it's constituent fields.
   Objects from these classes may be passed from input to output in hooks.
   These classes do override `hashCode` and `operator ==`.
   Examples: `CodeAsset`, `Architecture`, `OS`, `DataAsset`.

This changes `Metadata` and `EncodedAsset` to follow pattern 2 fully:

* All data is copied on construction.
* The map accessors do not allow modification.

This means the `hashCode` and `operator ==` are now correct.

We could consider changing `Metadata` and `EncodedAsset` to pattern 1, but I didn't want to refactor that code in this PR. For more details:

* https://github.com/dart-lang/native/issues/2045

Run Details

13 of 13 new or added lines in 3 files covered. (100.0%)

1 existing line in 1 file now uncovered.

13735 of 15967 relevant lines covered (86.02%)

35.56 hits per line