Mellanox / network-operator / 14070336206
62%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 56
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 59.948% (+0.2%) from 59.773%
14070336206

push

github

web-flow 
chore: bump github.com/onsi/ginkgo/v2 from 2.23.0 to 2.23.3 (#1397)

Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from
2.23.0 to 2.23.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/onsi/ginkgo/releases">github.com/onsi/ginkgo/v2's
releases</a>.</em></p>
<blockquote>
<h2>v2.23.3</h2>
<h2>2.23.3</h2>
<h3>Fixes</h3>
<ul>
<li>allow <code>-</code> as a standalone argument [cfcc1a5]</li>
<li>Bug Fix: Add GinkoTBWrapper.Chdir() and GinkoTBWrapper.Context()
[feaf292]</li>
<li>ignore exit code for symbol test on linux [88e2282]</li>
</ul>
<h2>v2.23.2</h2>
<h2>2.23.2</h2>
<p>🎉🎉🎉</p>
<p>At long last, some long-standing performance gaps between
<code>ginkgo</code> and <code>go test</code> have been resolved!</p>
<p>Ginkgo operates by running <code>go test -c</code> to generate test
binaries, and then running those binaries. It turns out that the
compilation step of <code>go test -c</code> is slower than <code>go
test</code>'s compilation step because <code>go test</code> strips out
debug symbols (<code>ldflags=-w</code>) whereas <code>go test -c</code>
does not.</p>
<p>Ginkgo now passes the appropriate <code>ldflags</code> to <code>go
test -c</code> when running specs to strip out symbols. This is only
done when it is safe to do so and symbols are preferred when profiling
is enabled and when <code>ginkgo build</code> is called explicitly.</p>
<p>This, coupled, with the <a
href="https://onsi.github.io/ginkgo/#if-you-are-running-on-macos">instructions
for disabling XProtect on MacOS</a> yields a much better performance
experience with Ginkgo.</p>
<h2>v2.23.1</h2>
<h2>2.23.1</h2>
<h2>🚨 For users on MacOS 🚨</h2>
<p>A long-standing Ginkgo performance issue on MacOS seems to be due to
mac's antimalware XProtect. You can follow the instructions <a
href="https://onsi.github.io/ginkgo/#if-you-are-running-on-macos">here</a>
to disable it in your terminal. Doing so sped up Ginkgo's own test suite
from 1m8s ... (continued)

3429 of 5720 relevant lines covered (59.95%)

36.84 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
2
83.33
 -2.38% controllers/ipoibnetwork_controller.go
4
75.24
 -3.81% pkg/state/state_ipoib_network.go
Jobs
ID Job ID Ran Files Coverage
1 14070336206.1 56
59.95
 GitHub Action Run
Source Files on build 14070336206