rust-bitcoin / rust-bitcoin / 14068638141

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4271: Make code style consistent and fix naming in macro Array implementations

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/e744347022d1ad1e0ca0a83ec9350501af08297b">e74434702<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/cf79f05ad68038b8d1e76d2773b6dbe3655b414f"> Make usage of Self and type uniform across both modules (Erick Cestari)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/dfb49f014c2c5194f9ae0c1c1e6910a6e1b6189d">dfb49f014</a> Rename impl_try_from_array to impl_from_array (Erick Cestari)

Pull request description:

  This PR makes two main changes:

  1. Standardizes the function signatures in the `Amount` and `SignedAmount` implementations by consistently using `Self` as the return type instead of the concrete type names. This improves code consistency, maintainability, and follows Rust's idiomatic practices.
  2. Renames `impl_try_from_array` to `impl_from_array` to better reflect its functionality.

  ### Changes
  **Consistent usage of Self instead of concrete types**

  - Replace all occurrences of `-> Amount` with `-> Self `in unsigned.rs
  - Replace all occurrences of `-> SignedAmount` with `-> Self` in signed.rs
  - Make similar replacements for Option/Result return types
  - Use `Self::` instead of explicit type name for static method calls

  **Function rename**

  Renamed `impl_try_from_array` to `impl_from_array` for better clarity

  ### Related Issues

  Closes #4210

  Closes #4241

ACKs for top commit:
  Kixunil:
    ACK e744347022d1ad1e0ca0a83ec9350501af08297b
  tcharding:
    ACK e744347022d1ad1e0ca0a83ec9350501af08297b
  apoelstra:
    ACK e744347022d1ad1e0ca0a83ec9350501af08297b; successfully ran local tests

Tree-SHA512: 3113f3ccfcb55a13658da87a1bc4958a3bb

Coverage Stats

31 of 38 new or added lines in 2 files covered. (81.58%)

3 existing lines in 2 files now uncovered.

22253 of 26617 relevant lines covered (83.6%)

16779.81 hits per line