14047623225
84%
master: 84%

Ran 24 Mar 2025 11:00PM UTC

Jobs 1

Files 24

Run time 1min

Badge

Embed ▾

Committed 24 Mar 2025 10:57PM UTC coverage: 83.608% (+0.03%) from 83.582%

Build # 14047623225

Build Type

Pull #241

github

Committed by

paskal

Commit Message

Set cookies for OAuth flows when SendJWTHeader is enabled

This fixes https://github.com/umputun/remark42/issues/1877 where OAuth
 authentication
fails when the send-jwt-header option is enabled. The problem occurred
 because:

1. When SendJWTHeader is enabled, the auth service only sends the JWT
as a header
   without setting cookies
2. During OAuth flows, the authentication involves redirects between
the app and the
   provider
3. HTTP headers don't persist through redirects, so the authentication
 state was lost

The solution:
- Modified the jwt.go token Set method to always set cookies during
OAuth handshake
  phases (when claims.Handshake != nil), even when SendJWTHeader is
enabled
- For normal authentication (non-handshake), maintain the original
behavior where
  SendJWTHeader=true will only set headers
- This ensures the OAuth flow works properly while maintaining the
correct behavior
  for API requests

Pull Request Pull Request #241: Set cookies for OAuth flows when SendJWTHeader is enabled

Run Details

2693 of 3221 relevant lines covered (83.61%)

7.19 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
8	90.36	0.2%	v2/token/jwt.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	14047623225.1	24 Mar 2025 11:00PM UTC	24	83.61	GitHub Action Run

go-pkgz / auth / 14047623225
84%
master: 84%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 14047623225

go-pkgz / auth / 14047623225 84% master: 84%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 14047623225

go-pkgz / auth / 14047623225
84%
master: 84%

README BADGES
x