sapcc / limes / 14023639065

79%

master: 80%

Build Type

Pull #674

github

Committed by majewsky

Commit Message

review: do not block renewal on a non-empty transfer status

There is currently no way for a user to reset the transfer status on a
commitment, so if a transfer is started and not completed, this would
block renewing the commitment, which is bad UX.

I understand that this restriction was meant to avoid a race condition
when a commitment is renewed at the same time as being transferred.
But both these operations touch the original commitment, so one of the
associated DB transactions would be forced to fail on commit. That's
good enough of a guarantee for me.

Pull Request Pull Request #674: Add commitment renewal endpoint

Run Details

109 of 135 new or added lines in 2 files covered. (80.74%)

139 existing lines in 3 files now uncovered.

6038 of 7598 relevant lines covered (79.47%)

61.56 hits per line