babelfish-for-postgresql / babelfish_extensions / 13989101108

77%

Build Type

push

github

Committed by web-flow

Commit Message

Prevent dropping of critical system views, functions, and procedures (#3480)

This commit introduces restrictions to prevent the dropping of essential system views, functions, and procedures within the dbo schema for both TSQL and PSQL dialects:

    sp_addlinkedserver
    syspolicy_configuration
    syspolicy_system_health_state
    fn_syspolicy_is_automation_enabled

Generalized the restriction mechanism for handling all kinds of objects.

Note: Only superusers can drop these restricted objects and since this couldn't be added in jdbc test, adding the output here for more info:

-- psql
babelfish_db=# DROP VIEW msdb_dbo.syspolicy_system_health_state;
DROP VIEW

Task: JIRA-5145, JIRA-5146

Signed-off-by: Roshan Kanwar <rskanwar@amazon.com>

Run Details

35 of 39 new or added lines in 2 files covered. (89.74%)

228 existing lines in 3 files now uncovered.

47584 of 63398 relevant lines covered (75.06%)

187743.47 hits per line