rust-bitcoin / rust-bitcoin / 13977478725

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4248: Alloc-free (AKA zero-copy) control block

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/9ea2e9262fbc04ea6fad33047de0fc1ead999dc7">9ea2e9262<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/20c50e337f203cbc5842aeed8270be1f89957ea7"> Don't use references to `TaprootMerkleBranchBuf` (Martin Habovstiak)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/c528f52894ed0e769aff3dd13bc0fee4087d47c1">c528f5289</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/20c50e337f203cbc5842aeed8270be1f89957ea7"> Change `Deref::Target` of `TaprootMerkleBranchBuf` (Martin Habovstiak)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/04a4efbe639a3546d31c777eb1e0d0176f05b573">04a4efbe6</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/20c50e337f203cbc5842aeed8270be1f89957ea7"> Introduce unsized `TaprootMerkleBranch` (Martin Habovstiak)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/370c2597c61c2a4ba9b688df4cef9464bd473dd8">370c2597c</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/20c50e337f203cbc5842aeed8270be1f89957ea7"> Add `as_mut_slice` to `TaprootMerkleBranchBuf` (Martin Habovstiak)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/33d75659dac697a9ffdb684fbd202ebcaf21505c">33d75659d</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/20c50e337f203cbc5842aeed8270be1f89957ea7"> Push `merkle_branch` module one level deeper. (Martin Habovstiak)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/277045bad7c4e9339d55e57ec425b0d0b46a5b58">277045bad</a> Add `Buf` suffix to `TaprootMerkleBranch` (Martin Habovstiak)

Pull request description:

  This implements a bunch of changes needed to make `ControlBlock` alloc-free. In particular, this allows constructing `Witness` without the intermediate allocation. It is also a step towards having `P2TrSpend` public.

  Closes #1614

  This also intentionally does **not** address decoding of `ControlBlock` from `Witness` since I'm not sure about the API.

  Rationale for doing the `Buf` rename: while doing it with `Script` was very painful it shouldn't be here since it's not used that often and also we can just backport the first commit with deprecated type alias. I was thinking of having `TaprootMerkleBr` but it'd be inconsistent and the name is silly.

  (Also if anyone is wondering why I did this: I was too exhausted to do more important stuff but felt like doing something nice and easy like this.)

ACKs for top commit:
  tcharding:
    ACK 9ea2e9262fbc04ea6fad33047de0fc1ead999dc7
  apoelstra:
    ACK 9ea2e9262fbc04ea6fad33047de0fc1ead999dc7; successfully ran local tests

Tree-SHA512: c5e3ea61d2043c500ba9a704201466fed9d

69 of 162 new or added lines in 5 files covered. (42.59%)

21969 of 26431 relevant lines covered (83.12%)

16814.9 hits per line