OpenRefine / OpenRefine / 13966588820

51%

push

github

Send absolute row index in request when "last" pagination button is clicked (#7211)

* fixes #7207

This change addresses how the "last" pagination navigation button sends
the ending point. The current behavior is that it sends the index of the
last row relative to a faceted search, and this change is to send the
index of the absolute last row in the project.
This also includes a change to omit the `nextPageStart` variable if
there are fewer than `limit` elements in the response. This will cause
the `next` and `last` pagination buttons to be marked as inactive, as
there are no more elements to paginate through.

* set totalRows to project row length and add tests

This commit changes the behavior of GetRowsCommand to return the total
number of rows in a project as the `totalRows` field, rather than
returning the filtered row count.
This commit also adds two tests to GetRowsCommandTest, to test that
pagination still works as expected when facets are applied.

5644 of 12768 branches covered (44.2%)

Branch coverage included in aggregate %.

14281 of 26938 relevant lines covered (53.01%)

2.46 hits per line