tarantool / luajit / 13952971335

93%

tarantool/master: 93%

Build Type

push

github

Committed by Buristan

Commit Message

Fix bit op coercion for shifts in DUALNUM builds.

Reported by Junlong Li.

(cherry picked from commit 69bbf3c1b)

This is a follow-up to the commit
8cd79d198 ("Fix bit op coercion in
DUALNUM builds."). After removing the coercion from
`lj_carith_check64()`, the bit shift operation may end in an infinite
loop in the case of infinite retrying to coerce the second operand from
number to integer TValue type.

This patch fixes that by unconditionally coercing the second argument in
the `LJLIB_ASM(bit_lshift)` fast function handler.

Sergey Kaplun:
* added the description and the test for the problem

Part of tarantool/tarantool#11055

Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org>
Signed-off-by: Sergey Kaplun <skaplun@tarantool.org>
(cherry picked from commit 148d575c7)

Run Details

5700 of 6038 branches covered (94.4%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

14 existing lines in 5 files now uncovered.

21735 of 23462 relevant lines covered (92.64%)

2966258.77 hits per line