safe-global / safe-client-gateway / 13919524672

89%

push

github

fix: only throw for new `eth_sign` signatures (#2460)

Proposals with `eth_sign` throw. As it is still possible to submit an `eth_sign` signature directly, however, this means that concatenated signatures already present from our API would also cause errors.

This adds a new check to proposal verification, only throwing for `eth_sign` signatures if they are not already present.

An added benefit from this is also that existing signatures are also verified again:

- Fetch proposed transaction
- Only throw if an `eth_sign` signature is new
- Add/update test coverage

3150 of 3799 branches covered (82.92%)

Branch coverage included in aggregate %.

3 of 4 new or added lines in 2 files covered. (75.0%)

10838 of 11660 relevant lines covered (92.95%)

569.57 hits per line