skeema / skeema / 13846526999

92%

push

github

internal: refactor string manipulations / replacements

This commit refactors some old code performing string replacements, mostly
in the tengo package. Changes in this commit include:

* Use strings.ReplaceAll where appropriate; this function was not available
  prior to Go 1.12 (Feb 2019) so older code used strings.Replace(..., ..., -1)

* Improve column comparison logic to avoid using unnecessary strings.Replace
  calls when coalescing older flavors' "utf8" with newer flavors' "utf8mb3"
  for charsets and collations

* Logic for escaping and unescaping strings now uses strings.Replacer to
  more efficiently perform these operations

Some test cases have been augmented to cover more situations for the above
changes. A few latent logic bugs have been fixed, but in edge cases that are
not believed to have been triggered in Skeema CLI code paths. Otherwise, no
changes in functionality expected.

36 of 36 new or added lines in 6 files covered. (100.0%)

10314 of 11072 relevant lines covered (93.15%)

1.11 hits per line