payjoin / rust-payjoin / 13838537049

83%

Build Type

push

github

Committed by web-flow

Commit Message

Add additional tests for v1 send module (#556)

Relates to #539 

These additional tests add more coverage for cargo mutant testing in
addition to removing `.unwrap()` where possible. For some of the missing
cargo mutant tests where the error occurs because of a change in
operator I have mostly avoided for now as I mainly focused on completely
missing test vectors.

Again I tried to make any modifications closely inline with #487 

Below are the mutants for `send/v1.rs` and `send/mod.rs` as of
df30f3b9d
<details>

```
// mod.rs
caught   payjoin/src/send/mod.rs:429:21: replace > with == in serialize_url in 7.6s build + 1.1s test
caught   payjoin/src/send/mod.rs:288:33: replace != with == in check_single_payee in 5.5s build + 1.1s test
caught   payjoin/src/send/mod.rs:241:45: replace < with > in PsbtContext::check_outputs in 6.0s build + 1.2s test
***MISSED   payjoin/src/send/mod.rs:431:67: replace / with * in serialize_url in 5.4s build + 1.5s test
caught   payjoin/src/send/mod.rs:154:54: replace == with != in PsbtContext::check_inputs in 6.3s build + 1.2s test
caught   payjoin/src/send/mod.rs:238:51: replace == with != in PsbtContext::check_outputs in 6.5s build + 1.3s test
caught   payjoin/src/send/mod.rs:241:45: replace < with == in PsbtContext::check_outputs in 5.7s build + 1.4s test
caught   payjoin/src/send/mod.rs:334:5: replace check_fee_output_amount -> Result<bitcoin::Amount, InternalBuildSenderError> with Ok(Default::default()) in 5.6s build + 0.9s test
***MISSED   payjoin/src/send/mod.rs:239:21: replace && with || in PsbtContext::check_outputs in 2.7s build + 0.8s test
***MISSED   payjoin/src/send/mod.rs:431:67: replace / with % in serialize_url in 13.5s build + 0.9s test
***MISSED   payjoin/src/send/mod.rs:262:53: replace == with != in PsbtContext::check_outputs in 1.6s build + 0.8s test
caught   payjoin/src/send/mod.rs:389:29: replace == with != in check_change_index in 1.6s build + 0.6s test
***MISSED   payj... (continued)

Run Details

157 of 164 new or added lines in 5 files covered. (95.73%)

2 existing lines in 1 file now uncovered.

4784 of 5938 relevant lines covered (80.57%)

778.19 hits per line