tarantool / tarantool / 13837075030
88%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 518
Run time 92min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 87.471% (-3.1%) from 90.525%
13837075030

push

github

locker 
vinyl: fix space truncation being aborted by yield under load

Under the hood, `space:truncate()` calls `space_vtab::build_index` to
notify the engine about index recreation, see `TruncateIndex::prepare`.
`space_vtab::build_index` isn't supposed to yield in this case because
the space is empty (note that `TruncateIndex::prepare` passes the new
space to the callback). However, there's a bug in vinyl that makes this
callback yield for no good reason, aborting `space:truncate()` with
`ER_TRANSACTION_YIELD`.

The problem lies in `vy_tx_manager_abort_writers_for_ddl()`, which is
called by `vinyl_space_build_index()` to abort all transactions that
write to the target space. If a transaction can't be aborted because
it has reached WAL, the function sets the `need_wal_sync` flag which
indicates the caller that they should call `wal_sync()` to flush all
unconfirmed transactions. In case of a space truncation, the function
should do nothing because there can't possibly be a transaction writing
to the new space, but actually it sets `need_wal_sync` if there's any
transaction waiting for WAL. This mistake doesn't lead to any problems
during an actual index build, but in case of a space truncation it
results in the transaction being aborted by a fiber yield.

Let's fix this problem by setting the `need_wal_sync` flag only if
there are transactions that actually write to the target space.

Closes #11249

NO_DOC=bug fix

70037 of 123601 branches covered (56.66%)

9 of 9 new or added lines in 1 file covered. (100.0%)

36 existing lines in 16 files now uncovered.

103169 of 117946 relevant lines covered (87.47%)

1904165.55 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
90.7
 -0.07% src/box/applier.cc
1
86.49
 -1.35% src/box/lua/ctl.c
1
95.05
 -0.31% src/box/raft.c
1
93.53
 -0.14% src/box/txn_limbo.c
1
95.74
 1.06% src/box/vy_range.c
1
95.4
 -1.15% src/lib/core/histogram.c
1
85.15
 -0.99% src/lib/small/small/slab_arena.c
2
92.44
 -0.09% src/box/vinyl.c
2
89.24
 -0.12% src/box/xrow.c
2
85.15
 -0.32% src/lib/core/say.c
2
94.22
 -0.39% src/lua/fiber.c
3
91.59
 -0.59% src/box/gc.c
3
90.9
 -0.31% src/box/vy_scheduler.c
3
22.64
 -0.04% src/lib/uri/uri_parser.c
4
91.3
 -0.13% src/box/box.cc
8
60.42
 -5.56% src/lib/core/fio.c
Jobs
ID Job ID Ran Files Coverage
1 13837075030.1 518
87.47
 GitHub Action Run
Source Files on build 13837075030