payjoin / rust-payjoin / 13825023058

83%

push

github

Add additional tests for v2 send module (#554)

Relates to #539 

This is an attempt to both add some additional test vectors and to
create some headway on the tests deficiencies caught by cargo mutants
ahead of time.

I have tried my best to keep the tests in accordance with the design
laid out in #487

Below is the cargo mutants output for `send/v2/mod.rs` as of
df30f3b9d

<details>

```
caught   payjoin/src/send/v2/mod.rs:203:5: replace serialize_v2_body -> Result<Vec<u8>, CreateRequestError> with Ok(vec![]) in 8.7s build + 1.1s test
caught   payjoin/src/send/v2/mod.rs:203:5: replace serialize_v2_body -> Result<Vec<u8>, CreateRequestError> with Ok(vec![1]) in 5.9s build + 1.1s test
***MISSED   payjoin/src/send/v2/mod.rs:146:45: replace > with == in Sender::extract_v2 in 10.2s build + 1.5s test
caught   payjoin/src/send/v2/mod.rs:203:5: replace serialize_v2_body -> Result<Vec<u8>, CreateRequestError> with Ok(vec![0]) in 8.5s build + 1.1s test
***MISSED   payjoin/src/send/v2/mod.rs:289:9: replace V2GetContext::process_response -> Result<Option<Psbt>, ResponseError> with Ok(None) in 8.6s build + 1.2s test
caught   payjoin/src/send/v2/mod.rs:146:45: replace > with < in Sender::extract_v2 in 66.0s build + 0.6s test
17 mutants tested in 1m 32s: 2 missed, 4 caught, 11 unviable
````

Note the 2 main improvements that can be made are for creating a test
for `process_response` and catching the
`test_extract_v2_fails_when_expired` slightly better

</details>

82 of 85 new or added lines in 2 files covered. (96.47%)

4659 of 5810 relevant lines covered (80.19%)

795.23 hits per line