PHPCSStandards / PHP_CodeSniffer / 13823399634

78%

master: 79%

Build Type

push

github

Committed by jrfnl

Commit Message

Ruleset: use `MessageCollector` for pre-existing errors

Notes:

**For the "invalid type" message**

Includes updating the message for the "invalid type" message to mention the reference for which the `type` was (incorrectly) being changed.
This should make it more straight forward for ruleset maintainers to find the problem in their ruleset.
It also makes the message more unique, as this message could occur in multiple places in a ruleset and there was no indication of that in the message previously.

Potential future scope for "invalid type" message

It could be considered to downgrade this message from an `ERROR` to a `NOTICE` as an invalid type is not blocking for running the sniffs, though this could lead to results not being as expected if, for instance, the `-n` flag is being used, which is why I've not changed this at this time.

**For the "register() method must return an array" error

Includes some new assertions which won't run until the test suite supports PHPUnit 10+ (PHPCS 4.0). These tests belong with this commit though, so adding them now anyway.

**For the "setting non-existent property" error

Includes minor adjustment to the error message (removal of "Ruleset invalid" and punctuation).

Run Details

17 of 21 new or added lines in 1 file covered. (80.95%)

67 existing lines in 1 file now uncovered.

19279 of 24878 relevant lines covered (77.49%)

76.76 hits per line