rust-bitcoin / rust-bitcoin / 13811079430

83%

Build Type

push

github

Committed by apoelstra

Commit Message

Merge rust-bitcoin/rust-bitcoin#4164: Prepare to enforce MAX_MONEY invariant

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/5d851f1c3e98d7d426e5897b2d734b77a299ccfb">5d851f1c3<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3cef539aacc017e94495d85e30e55f47b05231c3"> Remove deprecated amount methods (Tobin C. Harding)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/76a2d70b2866c9a9e2e24c1d71a9630a57559737">76a2d70b2</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3cef539aacc017e94495d85e30e55f47b05231c3"> Make mul weight by fee return NumOpResult (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/f9eb3079537ebc6d4a43121f7de839ba5b5018dc">f9eb30795</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3cef539aacc017e94495d85e30e55f47b05231c3"> Remove panic in dust value functions (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/13595fbe7d5ddcab0492445169297e009b6d6cc7">13595fbe7</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3cef539aacc017e94495d85e30e55f47b05231c3"> Fix amount whole bitcoin constructors (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/ac7168020274f2240aa6376b3aa12efc11c0aa57">ac7168020</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/3cef539aacc017e94495d85e30e55f47b05231c3"> Pick one - MAX or MAX_MONEY (Tobin C. Harding)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/6d70c77cf90a373041c93ac6e3a746f85a51b900">6d70c77cf Enforce newtype sanity rules for amount types (Tobin C. Harding)
e6f7b26d8 Use _unchecked in amount const types (Tobin C. Harding)
ef0af8d62 Use sat/ssat constructors throughout tests (Andrew Poelstra)
8ecdc7c27 Use den_ prefix for local Denomination variable (Tobin C. Harding)
938461cc6 psbt: Use Amount::ZERO in unit test (Tobin C. Harding)

Pull request description:

  We want to start enforcing MAX_MONEY as an invariant in the amount types. There are a few more steps we can do first to make that change easier to review.

ACKs for top commit:
  jamillambert:
    ACK 5d851f1c3e98d7d426e5897b2d734b77a299ccfb
  apoelstra:
    ACK 5d851f1c3e98d7d426e5897b2d734b77a299ccfb; successfully ran local tests

Tree-SHA512: 9e28b273d21b02bce78f75a61063cd61031

Coverage Stats

139 of 157 new or added lines in 8 files covered. (88.54%)

9 existing lines in 2 files now uncovered.

21640 of 26057 relevant lines covered (83.05%)

16982.05 hits per line