rust-bitcoin / rust-bitcoin / 13769734937

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4216: Replace underflow with overflow in doc comments

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/a273814d23f7f804f60bc260e6939a75ed9f1790">a273814d2<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/540038df904d11ddb6175bb9d050970a4b12d808"> Replace underflow with overflow in doc comments (yancy)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/2f897e210950242f9855403b056af0e74276e2ab">2f897e210</a> Remove warning section (yancy)

Pull request description:

  The use of underflow is misleading.  Adding one to MAX and subtracting one from MIN are both considered an overflow.

  Note I tried to keep to 80 column line length so a paragraph needed some shuffling.

  closes https://github.com/rust-bitcoin/rust-bitcoin/issues/4187

ACKs for top commit:
  Kixunil:
    ACK a273814d23f7f804f60bc260e6939a75ed9f1790
  tcharding:
    ACK a273814d23f7f804f60bc260e6939a75ed9f1790
  apoelstra:
    ACK a273814d23f7f804f60bc260e6939a75ed9f1790; successfully ran local tests

Tree-SHA512: 3d1fd3a6cdca8bac2161591b13a02ffb84b

1 of 1 new or added line in 1 file covered. (100.0%)

21700 of 26118 relevant lines covered (83.08%)

16836.3 hits per line