redhat-developer / yaml-language-server / 13764900112

84%

master: 80%

push

github

fix enum values to be unique (#1028)

* fix enum values to be unique

fix enum values to be unique

* when several schemas get combined (e.g., `oneOf`, `anyOf`) the available values for an `enum` could get merged
* this could lead to enum values present several time
* this PR only adds an enum values to the merged list, if its value is not present so far
* corresponding unit test is present as well

example:

schema:
```json
{
  "type": "object",
  "properties": {
    "animal": {
      "description": "should return this description",
      "anyOf": [
        {
          "enum": [ "cat", "dog", "non" ],
          "enumDescriptions": [ "", "Canis familiaris" ]
        },
        {
          "enum": [ "bird", "fish", "non" ],
          "enumDescriptions": [ "", "Special fish" ]
        }
      ]
    }
  }
}
```

Without the fix the `available value` list is: `[ cat, dog, non, bird, fish, non ]` with `non` being present twice.

With the fix the second `non` is removed, leaving only: `[ cat, dog, non, bird, fish ]`

* Update yamlHover.ts

---------

Co-authored-by: Muthurajan Sivasubramanian <93245779+msivasubramaniaan@users.noreply.github.com>

2135 of 2690 branches covered (79.37%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

3342 of 3806 relevant lines covered (87.81%)

9875.64 hits per line