jeffotoni / quick / 227

51%

Build Type

push

circleci

Committed by jeffotoni

Commit Message

Summary of Today's Refactoring in Quick

Today was the "D" day our refactoring further improved Quick, covering fundamental aspects of the framework.
I spent most of my time researching and seeing good practices, refactoring and doing all the test coverage.

Code Fixes and Improvements
1. Fix for the createParamsAndValid Function
• We adjusted the extraction of regex parameters, ensuring that the correct values were captured.
• We removed an unnecessary check ("/"+reqURI != builder.String()), since the URL reconstruction was already validated correctly.

2. Fix for the Listen and ListenWithShutdown Functions
• The server would shut down immediately because Listen did not block execution correctly. We implemented option 2, ensuring that the server remained active until it was shut down.

3. Compression Middleware (compress.Gzip)
• We improved the implementation of the Gzip middleware, ensuring the safe closure of the writer and adding the Vary: Accept-Encoding header.
• We created 100% covered tests, ensuring correct compression and decompression of the data.

Improved Testing and Full Coverage
4. We Created New Tests to Cover Unmet Cases
• We expanded the tests for createParamsAndValid, ensuring full coverage for different route and regex patterns.
• We fixed and ensured that extractBodyBytes correctly handled read errors.
• The mwWrapper function is now tested correctly for all middleware variants.

5. Increased Code Coverage
• We achieved full coverage in critical parts of the framework, fixing cases where errors were not tested properly.
• We improved test resilience, avoiding infinite loops and ensuring that all executions were validated correctly.

Run Details

114 of 118 new or added lines in 3 files covered. (96.61%)

4 existing lines in 2 files now uncovered.

2159 of 3811 relevant lines covered (56.65%)

2619.34 hits per line