safe-global / safe-client-gateway / 13692665302

89%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: create `SafeSignature` entity (#2422)

For every confirmation refined, we reference the owner and type of a signature. This is the same for transactions and messages.

This moves shared logic into a new `SafeSignature` entity, [taking inspiration from `safe-eth-py`](https://github.com/safe-global/safe-eth-py/blob/main/safe_eth/safe/safe_signature.py).

It takes the `hash` signed and `signature`, and exposes the `r`, `s`, `v`, `signatureType` and `owner` properties of them:

- Remove existing signature helpers
- Create `SafeSignature` entity
- Use entity in place for transaction/message verification
- Add/update test coverage accordingly

Run Details

3124 of 3781 branches covered (82.62%)

Branch coverage included in aggregate %.

80 of 85 new or added lines in 7 files covered. (94.12%)

2 existing lines in 2 files now uncovered.

10664 of 11467 relevant lines covered (93.0%)

507.33 hits per line