rust-bitcoin / rust-bitcoin / 13687342856

83%

push

github

Merge rust-bitcoin/rust-bitcoin#4189: Private key from slice fix

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/ecc5791930b88581fcbc8f2417b0221486bd1031">ecc579193<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/5ea4eac44211d6e23964123ef5140cd192f7486d"> Add test checking `XOnlyPublicKey::deserialize` (Martin Habovstiak)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/bbe87eccf2b9f01295e3c94a06130c6e7ac9bfa4">bbe87eccf</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/5ea4eac44211d6e23964123ef5140cd192f7486d"> Fix bug in PSBT `Deserialize` for `XOnlyPublicKey` (Martin Habovstiak)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/8efacd4dda359bffae2120dfd58942637f32a52c">8efacd4dd</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/5ea4eac44211d6e23964123ef5140cd192f7486d"> Deprecate `PrivateKey::from_slice` method (Martin Habovstiak)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/0d5cd7af435f420e76d2e69f0e76be30d230238e">0d5cd7af4</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/5ea4eac44211d6e23964123ef5140cd192f7486d"> Add `from_byte_array` to `PrivateKey`. (Martin Habovstiak)
1778fea66 Add a test checking `PrivateKey::from_slice` (Martin Habovstiak)
b87ddc004 Don't panic in `PrivateKey::from_slice` (Martin Habovstiak)

Pull request description:

  This fixes the bug introduced in #4154 and deprecates `from_slice` method in favor of `from_byte_array` (see commits).

  Closes #4191

ACKs for top commit:
  jamillambert:
    ACK ecc5791930b88581fcbc8f2417b0221486bd1031
  apoelstra:
    ACK ecc5791930b88581fcbc8f2417b0221486bd1031; successfully ran local tests

Tree-SHA512: 05117c68daef1fff015e5e800bb7e935c22

10 of 17 new or added lines in 2 files covered. (58.82%)

21554 of 25963 relevant lines covered (83.02%)

16776.88 hits per line