trento-project / web / 58b8c6889b42c49400837029d296f3d5d4395cc5
88%

DEFAULT BRANCH: main
Ran
Jobs 3
Files 468
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 85.424% (-0.03%) from 85.451%
58b8c6889b42c49400837029d296f3d5d4395cc5

push

github

web-flow 
Activity log severity levels UI (#3306)

* Adds initial implementation

- Adds an additional log level: critical
- Maps to appropriate icons on Overview page
- Adds severity field to modal

* Implements layout of filters

...according to the design proposal.

* Formatting

* Fixes failing tests

* Formatting

* Addresses comments

Certain comments addressed

* Fix for some failing tests

* Changes default server side query params

...debug level and above included if no severity value is present in request.

* Changes query/filter operator

Earlier we wanted level n and above, now all levels are to explicitly requested/opted-in

* Updates/fixes tests

This better reflects the newer implementation state with explicit opt-in and unbound/unused error level.

* Implements new client side defaults

... defaults for severity levels pre-selected

* Adds severity icons inline with text labels

* Formatting

* Fixes tests

restores earlier behaviour to the default case branch

* Formatting

* Fixes types

Previously it was assumed that Icons are strings when not null. Turns out they are objects. This commit addresses this fact.

* Fixes icon (auto-)sizing

According to design feedback.

* Implements new reset filters behavior

... according to design feedback

* Formatting

* Addresses comment

about importing and re-exporting

* Addresses PR comments

- Pulling out a function from jsx
- Rendering labels for the modal

* Adds gap

between icon and label

* Fixes failing e2e tests

* Formatting

3194 of 3739 relevant lines covered (85.42%)

752.4 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
93.75
 -3.13% lib/trento/activity_logging/severity_level.ex
Jobs
ID Job ID Ran Files Coverage
1 58b8c6889b42c49400837029d296f3d5d4395cc5.1 468
85.42
 GitHub Action Run
2 58b8c6889b42c49400837029d296f3d5d4395cc5.2 468
85.42
 GitHub Action Run
3 58b8c6889b42c49400837029d296f3d5d4395cc5.3 468
85.42
 GitHub Action Run
Source Files on build 58b8c6889b42c49400837029d296f3d5d4395cc5