rust-bitcoin
/
rust-bitcoin
/
13656057034
83%
|
Ran
|
Jobs
1
|
Files
123
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
coverage: 82.838%. Remained the same
push
github
apoelstraMerge rust-bitcoin/rust-bitcoin#4143: primitives: Inline small functions <a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/b656d7a16c2d0cdd6d8a94fffeac842ffc0fabf4">b656d7a16 Inline small functions (Jamil Lambert, PhD) Pull request description: Functions that fit the below criteria should be inline: > Basically, if a function jut delegates into another function and passing through arguments, it should be inline. Also when doing assignment of `u32` or similarly trivial operation. Also if it checks the validity of argument(s) and then performs something simple (like a call to `_unchecked`). _Originally posted by Kixunil in https://github.com/rust-bitcoin/rust-bitcoin/pull/4099#discussion_r1966156399_ Add `#[inline]` to all functions in `primitives` that fit the criteria. ACKs for top commit: tcharding: ACK b656d7a16c2d0cdd6d8a94fffeac842ffc0fabf4 apoelstra: ACK b656d7a16c2d0cdd6d8a94fffeac842ffc0fabf4; successfully ran local tests Tree-SHA512: 0059aa252ea801a20d7a771a2566db0ef5b
21165 of 25550 relevant lines covered (82.84%)
17014.8 hits per line
Coverage Regressions
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 6 |
69.05 |
0.0% | primitives/src/block.rs |
| 6 |
75.55 |
0.0% | primitives/src/transaction.rs |
| 2 |
83.76 |
0.0% | primitives/src/sequence.rs |
| 1 |
88.57 |
0.0% | primitives/src/locktime/absolute.rs |
| 1 |
74.21 |
0.0% | primitives/src/locktime/relative.rs |
| 1 |
94.75 |
0.0% | primitives/src/witness.rs |
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 13656057034.1 | 123 |
82.84 |
GitHub Action Run |
