neo-project / neo / 13649892034

79%

Build Type

push

github

Committed by web-flow

Commit Message

Implement NotaryAssisted transaction attribute (#3175)

* Implement NotaryAssisted transaction attribute

Close #2896. Use a stub for native Notary contract hash since this
contract is not implemented yet. Thus, technically, NotaryAssisted
attribute verification will always fail on real network until native
Notary is implemented.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* Payloads: add doc to CalculateNetworkFee method of NotaryAssisted attribute

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* Native: add NotaryAssisted attributes handler to Gas OnPersist

Transactions network fee should be split between Primary node and Notary
nodes.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* Payloads: adjust comment to NotaryAssisted attribute

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* Payloads: temporary use hard-coded Notary contract hash

Once Notary contract is implemented, this hash will be replaced by a
proper Notary contract hash. The exact value won't be changed since
Notary contract has constant hash as any other native contract.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* Payloads: replace hard-coded Notary hash value with calculated one

No functional changes, just a refactoring for better code readability.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* NeoModules: integrate NotaryAssisted attribute

Port the https://github.com/neo-project/neo-modules/pull/884.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* Payloads: fix XML comment formatting

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* P2P: move NotaryAssisted transaction attribute under D hardfork

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* P2P: move NotaryAssisted transaction attribute under E hardfork

D hardfork was occupied by 3.7.5, thus use the next available one.

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>

* tests: fix build errors

No functional changes, just build fixes required by updated maste... (continued)

Run Details

6039 of 8772 branches covered (68.84%)

Branch coverage included in aggregate %.

45 of 55 new or added lines in 5 files covered. (81.82%)

1 existing line in 1 file now uncovered.

22157 of 27190 relevant lines covered (81.49%)

128166.19 hits per line