msimerson / mail-dmarc / 429
75%

DEFAULT BRANCH: master
Ran
Jobs 6
Files 42
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
429

push

travis-ci

msimerson 
--geoip v6 support and field selection (#103)

* Use a larger integer type for `report_record`.`count`

- TINYINT UNSIGNED provides a range of 0-255.

- Maximum 255 is too small for some production reports,
	we have seen values of 400 or more.

- INTEGER UNSIGNED is way too large, but it avoids
	portability issues across different database systems.

- Otherwise SMALLINT UNSIGNED should be fine.

- To update existing databases you can issue:

	ALTER TABLE `report_record`
	MODIFY COLUMN `count`
	INT UNSIGNED DEFAULT NULL;

* Refactor.

- return and print geoip details in loop,
	like what we do for dns ptr lookup.

- move get_dns_hostname function down,
	to group geoip functions together.

* Drop unnecessary invocation.

- return value not used anywhere.

* Support granular --geoip flag.

- allow user to set:
	--geoip_country, --geoip_city, --geoip_continent.

- setting --geoip is equivalent to enabling all three flags.

* Modify --geoip options and functionality.

- Support both ipv4 and ipv6 address lookups.

	The Maxmind v6 database is required from now on,
		a v4 only database is no longer supported.

- Don't use multiple --geoip* flags, rather just use --geoip and allow
	the user to pass a comma delimited string with the geoip database fields.

	--geoip=country_name,continent_code
	--geoip=continent_code,country_name # keep the field order
	--geoup=city,city,city              # hang yourself
	--geoip                             # defaults to --geoip=country_name

* Avoid Net::IPv4Addr dependency.

- use a simple regex to check for ipv4.

- geoip lookup will fail anyway if ipv4 is malformed from origin.

- the downside is that it might be slightly slower to execute,
	since the geoip record lookup is still made.

* Add slightly more whitespace separation.

* Skip invalid fields rather than all geoip data.

- Originally thought that if the user passed a non-valid field type,
	we should return no geoip data.

* Remove dangling delimeter if field not available.

- calling $r->${f}() twice should not be a problem,
	because the lookup took place already.

* Change default --geoip fields.

- adhere with previous defaults.

* Update POD to document dmarc_view_report --geoip.

2699 of 3166 relevant lines covered (85.25%)

291.95 hits per line

Jobs
ID Job ID Ran Files Coverage
1 429.1 0
85.23
 Travis Job 429.1
2 429.2 0
85.23
 Travis Job 429.2
3 429.3 0
85.23
 Travis Job 429.3
4 429.4 0
85.23
 Travis Job 429.4
5 429.5 0
85.23
 Travis Job 429.5
6 429.6 0
85.23
 Travis Job 429.6
Source Files on build 429
Detailed source file information is not available for this build.