Qiskit / qiskit / 13637037739

89%

main: 88%

Build Type

push

github

Committed by web-flow

Commit Message

Fix qpy serialization of substitution of type `ParameterExpression` (backport #13890) (#13943)

* Fix qpy serialization of substitution of type `ParameterExpression` (#13890)

* Fix qpy serialization of substitution of type ParameterExpression

When substitution history `ParameterExpression._qpy_replay` is serialized,
there was no branch for the case that the substituted value is of type
`ParameterExpression`.
This commit fixes this oversight.

* Fix deserializing qpy written by previous writing fix

* Added a branch for reading `ParameterExpression` in _qpy_replay

* Added a missing argument (version) in an existing call in code path that
  was previously untested

* Remove a bit of useless code introduced in last commit

* run black

* Add tests

* Revert renaming extra_symbols to extra_expressions

Reverting this to minimize changes in order to make the PR safer to
backport.

* Revert cleaning up logic in _encode_replay_subs

This was a good change. But not necessary for the bug fix, which is
the main point of this PR.

* Add qpy compat test

* Bind parameter when checking for equality

* Run black after merge in browser

---------

Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
(cherry picked from commit a6fa6f87d)

# Conflicts:
#	test/qpy_compat/test_qpy.py

* Update test_qpy.py

* Update test/qpy_compat/test_qpy.py

---------

Co-authored-by: John Lapeyre <jlapeyre@users.noreply.github.com>
Co-authored-by: Elena Peña Tapia <57907331+ElePT@users.noreply.github.com>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

Run Details

4 of 4 new or added lines in 1 file covered. (100.0%)

14 existing lines in 2 files now uncovered.

79395 of 89352 relevant lines covered (88.86%)

358700.03 hits per line