Qiskit / qiskit / 13610480064

88%

Build Type

push

github

Committed by web-flow

Commit Message

Fix qpy serialization of substitution of type `ParameterExpression` (#13890)

* Fix qpy serialization of substitution of type ParameterExpression

When substitution history `ParameterExpression._qpy_replay` is serialized,
there was no branch for the case that the substituted value is of type
`ParameterExpression`.
This commit fixes this oversight.

* Fix deserializing qpy written by previous writing fix

* Added a branch for reading `ParameterExpression` in _qpy_replay

* Added a missing argument (version) in an existing call in code path that
  was previously untested

* Remove a bit of useless code introduced in last commit

* run black

* Add tests

* Revert renaming extra_symbols to extra_expressions

Reverting this to minimize changes in order to make the PR safer to
backport.

* Revert cleaning up logic in _encode_replay_subs

This was a good change. But not necessary for the bug fix, which is
the main point of this PR.

* Add qpy compat test

* Bind parameter when checking for equality

* Run black after merge in browser

---------

Co-authored-by: Luciano Bello <bel@zurich.ibm.com>

Run Details

4 of 4 new or added lines in 1 file covered. (100.0%)

27 existing lines in 3 files now uncovered.

76073 of 87480 relevant lines covered (86.96%)

333078.98 hits per line