ledgersmb / LedgerSMB / 13605561301

48%

master: 63%

Build Type

push

github

Committed by web-flow

Commit Message

1.12 backport Bank Account Screen fixes (#8700)

* Add labels to Bank Account data entry fields

Previously just three unlabelled text boxes. This adds labels and
renders them correctly aligned in the two-column grid.

* Fix delete bank account

Deleting a bank account from the Entity bank account tab failed with an
error, because the required arguments were not passed through to the
underlying database function. Fixed.

* Update Changelog

* Update Changelog

* Make bic field required on Bank Account screen

`entity_bank_account.bic` is a required field in the underlying
database. Make this a required field on the UI to allow client-side
validation.

* Add explicit closing tags to Bank Account page markup

Commit c90ddfac5 introduced
self-closing `<lsmb-text />` tags, which our HTML linter complains
about. Fixed with `<lsmb-text>...</lsmb-text>` tags.

Run Details

122 of 143 branches covered (85.31%)

0 of 1 new or added line in 1 file covered. (0.0%)

112 existing lines in 8 files now uncovered.

9870 of 20906 relevant lines covered (47.21%)

477.8 hits per line