Qiskit / qiskit / 13595577475

88%

Build Type

push

github

Committed by web-flow

Commit Message

C API for ``SparseObservable`` (#13694)

* Split ``PySparseObservable`` or ``SparseObservable``

* reno and docs

* rm Arc<RwLock> for SparseTerm

* add Into(Py) for SparseObservable

* rm Rust-side PySparseObservable.clone

* smaller fixes

- avoid using &Vec
- add unsafe to mutable indices/boundaries
- rm upgrade reno

* move back into 1 file

* use Arc::ptr_eq over .is()

* C API for SparseObservable

Co-authored-by: Max Rossmannek <oss@zurich.ibm.com>

* Add struct/enum prefix

* Bring trait impls closer to structs

* review comments

- use Arc<> instead of Py<> in ArrayView
- py_sparse.. -> sparse_

* fix test imports

* attempt 1 to add CI integration

* thine tools shall obey thou holy pylint

* fix cbindgen dep

* add clang format to CI lint

* fix tox

* reno draft

some of this might need to be updated once we add the Docs

* updates from discussion w/ Jake

- use pointers instead of refs
- add safety sections in the docs
- add a SparseObservable.new from raw data
- enable alignment check (possible w/ new MSRV)
- pass bitterm (u8) by value

* round 1 of review comments

- mainly SAFETY sections
- improve formatting tools
- location and import of header

* left over small comments

* Rework print function to return string

This commit reworks the print obs and obsterm functions which just
called printf internally and instead replaces them with new `_str()`
and `free_*_str()` functions to both return a string and free a string
representation of a sparse observable and term. This enables debugging
but without forcing you to stdout. Managing the stdout buffers between
2 or 3 languages isn't really feasible, so having a string generator
function lets the C user do whatever they need with the string repr.

* Tidy up README code

* Fix incorrect documentation

* Fix missing includes

As an implementation detail, `qiskit.h` includes `stdint.h` and
`stdbool.h`, but we use their items explicitly, so best to be explicit.

Fixup includes

* Correct C co... (continued)

Run Details

4 of 4 new or added lines in 1 file covered. (100.0%)

5 existing lines in 3 files now uncovered.

76036 of 87426 relevant lines covered (86.97%)

333787.88 hits per line