tarantool / tarantool / 13591076917
88%
master: 88%

LAST BUILD BRANCH: fix-test-dir-for-gitlab-ci
DEFAULT BRANCH: master
Ran
Jobs 1
Files 518
Run time 26min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 87.454% (-0.02%) from 87.477%
13591076917

push

github

locker 
test/vinyl/select_consistency: make garbage check more robust

The test fails now and then on CI with:

```
[035] vinyl-luatest/select_consistency_test.lua                     [ fail ]
[035] Test failed! Output from reject file /tmp/t/rejects/vinyl-luatest/select_consistency.reject:
[035] Tarantool version is 2.11.7-entrypoint-10-g130294905b
[035] TAP version 13
[035] 1..2
[035] # Started on Thu Feb 27 09:21:34 2025
[035] # Starting group: vinyl.select_consistency.defer_deletes:false
[035] ok     1	vinyl.select_consistency.defer_deletes:false.test_select_consistency
[035] # Starting group: vinyl.select_consistency.defer_deletes:true
[035] not ok 2	vinyl.select_consistency.defer_deletes:true.test_select_consistency
[035] #   ...tarantool/test/vinyl-luatest/select_consistency_test.lua:296: expected: 675, actual: 1094
[035] #   stack traceback:
[035] #   	...tarantool/test/vinyl-luatest/select_consistency_test.lua:296: in function <...tarantool/test/vinyl-luatest/select_consistency_test.lua:273>
[035] #   	...tarantool/test/vinyl-luatest/select_consistency_test.lua:273: in function 'vinyl.select_consistency.defer_deletes:true.test_select_consistency'
[035] #   artifacts:
[035] #   	master -> /tmp/t/035_vinyl-luatest/artifacts/master-Fp1zE14Fq-Dr
[035] # Ran 2 tests in 12.841 seconds, 1 succeeded, 1 failed
```

The test fails while checking that there's no garbage statements in
the test space. We already fixed this failure in the scope of #11019:
the reason was that `index:compact()` didn't work if it raced with range
splitting. Now, the problem is different and it's in the test itself.

First, there may be compaction tasks still running after the test is
complete. We should wait for them before forcing major compaction and
checking the counters, otherwise major compaction may be skipped.

Second, a single run file may contain garbage statements that were
not compacted because they were visible from some read view. Since
`index:compact()` doesn't trigger ... (continued)

69862 of 123713 branches covered (56.47%)

102863 of 117620 relevant lines covered (87.45%)

2236843.43 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
86.49
 -1.35% src/box/lua/ctl.c
1
92.42
 0.05% src/box/vinyl.c
1
84.37
 0.11% src/box/xlog.c
1
80.0
 -2.05% src/lib/core/clock.c
1
90.38
 -1.92% src/lib/core/trigger.cc
2
85.71
 -9.52% src/lib/core/tt_sigaction.c
3
90.7
 -0.22% src/box/applier.cc
3
95.04
 -0.19% src/box/xrow_update_field.c
4
97.05
 -0.41% src/lib/msgpuck/msgpuck.h
4
93.31
 -1.27% src/lib/swim/swim_io.c
6
94.66
 -1.03% src/box/vy_read_iterator.c
9
88.14
 -7.63% src/box/vy_regulator.c
20
90.82
 -0.57% src/box/box.cc
Jobs
ID Job ID Ran Files Coverage
1 13591076917.1 518
87.45
 GitHub Action Run
Source Files on build 13591076917