tarantool / tarantool / 13591006230

88%

push

github

test/vinyl/select_consistency: make garbage check more robust

The test fails now and then on CI with:

```
[035] vinyl-luatest/select_consistency_test.lua                     [ fail ]
[035] Test failed! Output from reject file /tmp/t/rejects/vinyl-luatest/select_consistency.reject:
[035] Tarantool version is 2.11.7-entrypoint-10-g130294905b
[035] TAP version 13
[035] 1..2
[035] # Started on Thu Feb 27 09:21:34 2025
[035] # Starting group: vinyl.select_consistency.defer_deletes:false
[035] ok     1	vinyl.select_consistency.defer_deletes:false.test_select_consistency
[035] # Starting group: vinyl.select_consistency.defer_deletes:true
[035] not ok 2	vinyl.select_consistency.defer_deletes:true.test_select_consistency
[035] #   ...tarantool/test/vinyl-luatest/select_consistency_test.lua:296: expected: 675, actual: 1094
[035] #   stack traceback:
[035] #   	...tarantool/test/vinyl-luatest/select_consistency_test.lua:296: in function <...tarantool/test/vinyl-luatest/select_consistency_test.lua:273>
[035] #   	...tarantool/test/vinyl-luatest/select_consistency_test.lua:273: in function 'vinyl.select_consistency.defer_deletes:true.test_select_consistency'
[035] #   artifacts:
[035] #   	master -> /tmp/t/035_vinyl-luatest/artifacts/master-Fp1zE14Fq-Dr
[035] # Ran 2 tests in 12.841 seconds, 1 succeeded, 1 failed
```

The test fails while checking that there's no garbage statements in
the test space. We already fixed this failure in the scope of #11019:
the reason was that `index:compact()` didn't work if it raced with range
splitting. Now, the problem is different and it's in the test itself.

First, there may be compaction tasks still running after the test is
complete. We should wait for them before forcing major compaction and
checking the counters, otherwise major compaction may be skipped.

Second, a single run file may contain garbage statements that were
not compacted because they were visible from some read view. Since
`index:compact()` doesn't trigger ... (continued)

69901 of 123367 branches covered (56.66%)

102996 of 117770 relevant lines covered (87.46%)

2220213.94 hits per line