adobe / spectrum-web-components / 13553587344
98%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 388
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 97.966% (-0.2%) from 98.185%
13553587344

push

github

web-flow 
fix(action menu): keyboard accessibility omnibus (#5031)

* fix(menu): added rovingTabindexController and removed aria-activedescendant

* fix(menu): fixes firefox keyboard navigation and call stack issues

* test(menu): updates menu test based on changes

* test(menu): adds click test for accessibility

* test(menu): menu itself should delegate focus to active item

* fix(menu): fixed menu group navigation according WAI ARIA APG

* fix(reactive-controllers): complex element delegates focus to active child WAI ARIA APG

* fix(menu): components should delegate focus

* fix(menu): update keyboard nav to match WAI ARIA APG

* fix(menu): updated docs to reflect preferred accessible method

* fix(menu): selection and keyboard navigation according to APG

* test(menu): updated to recommended a11y behavior from APG

* docs(menu): reverted docs but fixed typos

* fix(menu): removed unused map

* test(menu): updated test to match changed group id

* test(menu): keyboard selection is fixed

* test(menu): updated to reflect WAI ARIA APG

* fix(picker): picker should delegate focus

* fix(action-menu): fixed a11y error message

* fix(picker): according to APG ArrowDown should focus on first item

* test(action-menu): updated tests for focus delegation and APG keyboard nav

* fix(picker): ensure overlay is open before setting focus

* fix(menu): removed extra focus

* chore: added changeset

* fix(picker): prevents the picker button from getting focus when menu is first updated

* fix(menu): fixes preventDefault behavior when Space is pressed

* fix(menu): accounted for action menus with no selection

* fix(picker):sets focus on first selected item

* fix(picker): focuses on 1st selected item when opened via kbd

* test(picker): updated tests based on APG kbd nav

* fix(menu): when I menuitem with a submenu closes

* fix(picker): leverages RTI for ArrowLeft/ArrowRight

* fix(picker): leverages RTI for ArrowLeft/ArrowRight

* test(picker): adjusted tests based on a... (continued)

5294 of 5601 branches covered (94.52%)

Branch coverage included in aggregate %.

627 of 678 new or added lines in 11 files covered. (92.48%)

27 existing lines in 8 files now uncovered.

33662 of 34164 relevant lines covered (98.53%)

644.4 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
2
83.33
 -2.74% packages/picker/src/MobileController.ts
3
95.54
 -0.47% packages/menu/src/Menu.ts
3
97.47
 -1.21% tools/reactive-controllers/src/FocusGroup.ts
4
96.53
 -0.44% packages/combobox/src/Combobox.ts
8
96.32
 -2.32% packages/picker/src/Picker.ts
15
95.01
 -1.57% packages/menu/src/MenuItem.ts
16
89.84
 -8.85% packages/action-menu/src/ActionMenu.ts

Uncovered Existing Lines

Lines Coverage ∆ File
1
95.01
 -1.57% packages/menu/src/MenuItem.ts
2
90.83
 -2.75% packages/picker/src/DesktopController.ts
2
94.35
 -0.94% packages/picker/src/InteractionController.ts
2
98.34
 -0.41% packages/tabs/src/Tabs.ts
2
99.32
 -0.46% tools/shared/src/focusable.ts
3
95.54
 -0.47% packages/menu/src/Menu.ts
3
97.47
 -1.21% tools/reactive-controllers/src/FocusGroup.ts
12
96.32
 -2.32% packages/picker/src/Picker.ts
Jobs
ID Job ID Ran Files Coverage
1 13553587344.1 388
97.97
 GitHub Action Run
Source Files on build 13553587344