13543542822
88%

Ran 26 Feb 2025 12:25PM UTC

Jobs 1

Files 518

Run time 232min

Badge

Embed ▾

Committed 26 Feb 2025 12:10PM UTC coverage: 87.46% (-0.01%) from 87.473%

Build # 13543542822

Build Type

push

github

Committed by

locker

Commit Message

txn: do not call engine rollback_statement if begin_statement failed

If vinyl_engine_begin_statement() fails, it leaves engine_savepoint
unset. As a result, vinyl_engine_rollback_statement() called afterwards
by txn_begin_stmt() assumes there were no entries in vy_tx::log before
the statement was begun and rolls back everything. If there were
statements, an attempt to roll them back triggers a crash.

Let's fix this issue by skipping invocation of the rollback_statement
engine callback in case begin_statement failed. We achieve that by
leaving txn::engine and txn::space unset on failure.

Fixes commit b9c5a1d96410 ("txn: enable cross-engine transactions").

Closes #11187
Follow-up #1803

NO_DOC=bug fix
NO_CHANGELOG=unreleased

Run Details

69827 of 123293 branches covered (56.64%)

5 of 5 new or added lines in 1 file covered. (100.0%)

37 existing lines in 12 files now uncovered.

102914 of 117670 relevant lines covered (87.46%)

2204154.03 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	90.7	-0.07%	src/box/applier.cc
1	86.49	-1.35%	src/box/lua/ctl.c
1	95.05	-0.31%	src/box/raft.c
1	96.12	-0.18%	src/box/relay.cc
1	95.78	-0.12%	src/box/replication.cc
1	92.55	0.05%	src/box/vinyl.c
1	90.9	-0.1%	src/box/vy_scheduler.c
2	84.32	-0.11%	src/box/xlog.c
2	85.71	-9.52%	src/lib/core/tt_sigaction.c
3	92.94	-0.09%	src/lib/core/fiber.c
3	22.64	-0.06%	src/lib/uri/uri_parser.c
20	90.76	-0.64%	src/box/box.cc

Jobs

ID	Job ID	Ran	Files	Coverage
1	13543542822.1	26 Feb 2025 12:25PM UTC	518	87.46	GitHub Action Run

tarantool / tarantool / 13543542822
88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 13543542822

tarantool / tarantool / 13543542822 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 13543542822

tarantool / tarantool / 13543542822
88%

README BADGES
x